[CALCITE-5212] Include DECIMAL scale in digest when precision unspecified #4937
Open
AlexisCubilla wants to merge 1 commit into
Open
[CALCITE-5212] Include DECIMAL scale in digest when precision unspecified #4937AlexisCubilla wants to merge 1 commit into
AlexisCubilla wants to merge 1 commit into
Conversation
…specified Problem: createSqlType(DECIMAL, PRECISION_NOT_SPECIFIED, scale) could return types that collided in DATATYPE_CACHE: same digest/hash for different scales because BasicSqlType.generateTypeString() only appended scale when printPrecision was true, so scale was omitted when precision was PRECISION_NOT_SPECIFIED. Root cause: The digest string did not distinguish DECIMAL types that differed only by scale while precision stayed unspecified, breaking equals/hashCode/canonize. Fix: When precision is not specified but scale is, append "(PRECISION_NOT_SPECIFIED, scale)" to the digest for DECIMAL (see generateTypeString). Testing: ./gradlew :core:test --tests "org.apache.calcite.sql.type.SqlTypeFactoryTest" https://issues.apache.org/jira/browse/CALCITE-5212
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[CALCITE-5212] Include DECIMAL scale in type digest when precision unspecified
Problem:
createSqlType(DECIMAL, PRECISION_NOT_SPECIFIED, scale) could return types that
collided in DATATYPE_CACHE: same digest/hash for different scales because
BasicSqlType.generateTypeString() only appended scale when printPrecision was
true, so scale was omitted when precision was PRECISION_NOT_SPECIFIED.
Root cause:
The digest string did not distinguish DECIMAL types that differed only by
scale while precision stayed unspecified, breaking equals/hashCode/canonize.
Fix:
When precision is not specified but scale is, append "(PRECISION_NOT_SPECIFIED, scale)"
to the digest for DECIMAL (see generateTypeString).
Testing:
./gradlew :core:test --tests "org.apache.calcite.sql.type.SqlTypeFactoryTest"
https://issues.apache.org/jira/browse/CALCITE-5212